HTML API: Preserve raw text contents in serialize#54
Open
sirreal wants to merge 2 commits into
Open
Conversation
The serializer was discarding the raw-text contents of IFRAME, NOEMBED, and NOFRAMES even though get_modifiable_text() already returns the browser-equivalent raw text for those elements. Let those elements follow the same raw emission path as SCRIPT and STYLE, preserving contents while retaining existing NUL and newline normalization. See #65372.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IFRAME,NOEMBED, andNOFRAMES.Root cause
WP_HTML_Processor::serialize_token()recognizes these elements as self-contained raw-text elements, but explicitly replaced their modifiable text with an empty string before appending the serialized closing tag. As a result,normalize()and full-documentserialize()dropped parsed contents such as<iframe>x</iframe>to<iframe></iframe>.Behavioral impact
Serialization now preserves the contents of
IFRAME,NOEMBED, andNOFRAMESliterally, including markup-like text, character references, and NUL-byte replacement. Coverage includes fragment normalization and full-document serialization, includingNOFRAMESinHEADandFRAMESETcontexts.Why literal emission is correct
These contents come from the parser's raw-text handling. Character references are not decoded there, and NUL bytes have already followed the parser/tokenizer replacement behavior exposed by
get_modifiable_text(). Escaping or dropping the text changes the parsed document; emitting it literally preserves serialize/re-parse fidelity for the parser-derived contents. This serializer behavior is not a sanitizer and does not broadenset_modifiable_text(), which continues to reject edits to these elements.Validation
WP_TESTS_SKIP_INSTALL=1 ./vendor/bin/phpunit --group html-api --filter Tests_HtmlApi_WpHtmlProcessor_Serialize- OK (101 tests, 174 assertions)vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-includes/html-api/class-wp-html-processor.php tests/phpunit/tests/html-api/wpHtmlProcessor-serialize.php- OKSee #65372.